use cross platform path separatator in build #5085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Sep 6, 2018
Member
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
martijnhoekstra
force-pushed
the
winbuild
branch
from
86d3b60 to
0a7ecd8
Compare
sjrd
reviewed
Sep 6, 2018
project/Build.scala
Outdated
| .map(_.data.getAbsolutePath) | ||
| .find(_.contains(name)) | ||
| .toList.mkString(":") | ||
| .toList.mkString(java.io.File.pathSeparatorChar.toString) |
Member
There was a problem hiding this comment.
pathSeparator can be used instead of pathSeparatorChar.toString.
smarter
approved these changes
Sep 6, 2018
Member
smarter
left a comment
smarter
left a comment
There was a problem hiding this comment.
While you're at it, you may want to grep for ":" in the codebase, there's quite a few place where we should be use pathSeparator too.
martijnhoekstra
force-pushed
the
winbuild
branch
2 times, most recently
from
afa7b6b to
6379ecf
Compare
Contributor
Author
|
I think I caught all platform-incompatible uses of |
martijnhoekstra
force-pushed
the
winbuild
branch
from
6379ecf to
0b0c763
Compare
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, world!
build instructions now work on Windows.