Skip to content

Forbid private override modifier combination #5076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2018
Merged

Forbid private override modifier combination #5076

merged 1 commit into from
Sep 4, 2018

Conversation

@allanrenucci
Copy link
Contributor

@allanrenucci allanrenucci commented Sep 4, 2018

No description provided.

OlivierBlanvillain
OlivierBlanvillain approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@OlivierBlanvillain OlivierBlanvillain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlivierBlanvillain
Copy link
Contributor

OlivierBlanvillain commented Sep 4, 2018

Fixes #5052

@allanrenucci allanrenucci merged commit 28c73f4 into scala:master Sep 4, 2018
@allanrenucci allanrenucci deleted the fix-5052 branch September 4, 2018 11:20
@allanrenucci
Copy link
Contributor Author

allanrenucci commented Sep 4, 2018

Fixes #5052

Oops, forgot to include it in the commit message

@allanrenucci allanrenucci mentioned this pull request Sep 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@OlivierBlanvillain OlivierBlanvillain OlivierBlanvillain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@allanrenucci @OlivierBlanvillain