Fix #5007 (aka scala/bug#5063) #5029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on scala/scala@bed3304bf86 and Nicolas' suggestion.
Closed
| || (from.tpe isRef defn.NothingClass) | ||
| || (from.tpe isRef defn.NullClass) | ||
| || !(ctx.mode is Mode.ImplicitsEnabled) | ||
| || from.isInstanceOf[Super] |
Contributor
There was a problem hiding this comment.
This test is pretty cheap compared to the other ones. I'm wondering if it is better moved earlier
Contributor
Author
There was a problem hiding this comment.
Ah, I didn't wonder about that... Super is also pretty rare so I'm not sure, but scala/scala@bed3304bf86 still puts it early.
Contributor
Author
There was a problem hiding this comment.
Sorry — I meant to agree on your suggestion but I'm away. I can review your PR for this change.
allanrenucci
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5007 (aka scala/bug#5063).
Based on scala/scala@bed3304bf86 and Nicolas' suggestion.