Fix ambiguous unapply for TASTy reflect Parent #4998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Aug 26, 2018
| } | ||
| } | ||
|
|
||
| def termAsParent(term: Term): Parent = term |
Contributor
There was a problem hiding this comment.
This seems dangerous to me, as any term can now be disguised as Parent. The same for TypeTree. Conceptually, how it is different from making Parent a supertype of Term and TypeTree?
Contributor
Author
There was a problem hiding this comment.
It is not conceptually different, but it solves the ambiguity in the extractor when passing a Term as term could be a Tree or a Parent. This will be removed when we bootstrap and I'll be able to define type Parent = Term | TypeTree and have a simple extractor for both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.