Use symbol instead of definition tree in TASTy reflect #4991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
use-tasty-reflect-symbols
branch
from
1ca6384 to
a2a18d3
Compare
nicolasstucki
force-pushed
the
use-tasty-reflect-symbols
branch
from
a2a18d3 to
2ee909f
Compare
nicolasstucki
force-pushed
the
use-tasty-reflect-symbols
branch
from
666d9d1 to
18bb14c
Compare
Merged
liufengyun
approved these changes
Aug 24, 2018
Contributor
liufengyun
left a comment
liufengyun
left a comment
There was a problem hiding this comment.
Vive les symboles 👍 LGTM
| def isEmpty: Boolean = symbol eq NoSymbol | ||
| def localContext(implicit ctx: Context): Context = ctx.withOwner(symbol) | ||
|
|
||
| def isEmpty(implicit ctx: Context): Boolean = symbol eq NoSymbol |
Contributor
There was a problem hiding this comment.
Can we rename it to exists? Not important, somehow I feel exists is more friendly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefinitiontoSymbolto avoid unnecessary loading of treesSymbolinstead ofDefinitionavoid unnecessary loading of treesSymbol