Skip to content

Fix printing of type in type test warnings #4898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2018
Merged

Fix printing of type in type test warnings #4898

merged 1 commit into from
Aug 6, 2018

Conversation

@allanrenucci
Copy link
Contributor

@allanrenucci allanrenucci commented Aug 6, 2018 •
edited
Loading

The i interpolator calls show on its arguments

@allanrenucci allanrenucci requested a review from liufengyun August 6, 2018 10:03
Blaisorblade
Blaisorblade approved these changes Aug 6, 2018
View reviewed changes
Copy link
Contributor

@Blaisorblade Blaisorblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — types have been completed so this should be safe.

@allanrenucci allanrenucci merged commit a4a611c into scala:master Aug 6, 2018
@allanrenucci allanrenucci deleted the fix-reporting branch August 6, 2018 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liufengyun liufengyun Awaiting requested review from liufengyun

1 more reviewer

@Blaisorblade Blaisorblade Blaisorblade approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@liufengyun liufengyun

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@allanrenucci @Blaisorblade @liufengyun