Skip to content

Address review in JLine PR #4745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2018
Merged

Address review in JLine PR #4745

merged 1 commit into from
Jun 30, 2018

Conversation

@allanrenucci
Copy link
Contributor

@allanrenucci allanrenucci commented Jun 30, 2018 •
edited
Loading

Should be called cursorNotAtEnd no? In any case, it's a bit confusing that the comment above describes the conditions for submitting, but the code checks the conditions for not submitting, either the code logic or the comment should be changed.

I missed this comment in the JLine PR

@allanrenucci allanrenucci requested a review from smarter June 30, 2018 09:24
@allanrenucci allanrenucci merged commit f2efe05 into scala:master Jun 30, 2018
@allanrenucci allanrenucci deleted the repl branch June 30, 2018 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarter smarter smarter approved these changes

Assignees

@smarter smarter

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@allanrenucci @smarter