Add tests example of a partially unrolled loop #4736
Conversation
| System.out.println(2 * x) | ||
| } | ||
|
|
||
| /* unrooled code: |
There was a problem hiding this comment.
You can add a test to https://github.com/lampepfl/dotty/blob/master/compiler/test/dotty/tools/backend/jvm/InlineBytecodeTests.scala to check that the code produced by the compiler actually is what you think it is.
There was a problem hiding this comment.
I don't thinks InlineBytecodeTests.scala supports separate compilation. Not sure how much work it would be to make it support it. It is probably better to just test the code directly.
There was a problem hiding this comment.
What do you mean by "test the code directly"? You're doing code generation here, if you don't test that the code you generate looks like the way you think it should look like, I can guarantee you that you will have hard-to-find bugs.
There was a problem hiding this comment.
I mean test the high-level code generated instead of the final bytecode.
nicolasstucki
force-pushed
the
quoted-unrolled-loop
branch
from
b949c3a to
2f5913e
Compare
nicolasstucki
force-pushed
the
quoted-unrolled-loop
branch
from
a37fd8a to
8d209a2
Compare
3 participants
No description provided.