Fix -Ythrough-tasty #4664
Merged
Fix -Ythrough-tasty #4664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
suggested changes
Jun 15, 2018
|
|
||
| val ext = "hasTasty" | ||
| val classes = Directory(fromSourcesOut).walk.filter(x => x.isFile && x.extension == ext).map { x => | ||
| val extensions = List("tasty", "hasTasty") |
Contributor
There was a problem hiding this comment.
List("tasty", "hasTasty").toLowerCase intead of on each file
| val ext = "hasTasty" | ||
| val classes = Directory(fromSourcesOut).walk.filter(x => x.isFile && x.extension == ext).map { x => | ||
| val extensions = List("tasty", "hasTasty") | ||
| val classes = Directory(fromSourcesOut).walk.filter(x => x.isFile && extensions.exists(_.toLowerCase == x.extension)).map { x => |
Contributor
There was a problem hiding this comment.
Is extension supposed to always return lower cases? If not, we should do x.extension.toLowerCase to make sure it is as we expected.
smarter
force-pushed
the
fix/YthroughTasty
branch
from
8a2934c to
2d7a660
Compare
|
|
||
| val ext = "hasTasty" | ||
| val classes = Directory(fromSourcesOut).walk.filter(x => x.isFile && x.extension == ext).map { x => | ||
| val extensions = List("tasty", "hasTasty").toLowerCase |
Contributor
There was a problem hiding this comment.
List("tasty", "hasTasty").map(_.toLowerCase), my bad
- dotty.tools.io.Path#extension always return something lowercase for some reason, so comparing against "hasTasty" always returned false - .tasty files were not supported
smarter
force-pushed
the
fix/YthroughTasty
branch
from
2d7a660 to
bde19ec
Compare
nicolasstucki
approved these changes
Jun 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some reason, so comparing against "hasTasty" always returned false