Skip to content

Fix #4623: Don't check for repeated parents in refinement classes #4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2018
Merged

Fix #4623: Don't check for repeated parents in refinement classes #4641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion compiler/src/dotty/tools/dotc/typer/Typer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1491,7 +1491,8 @@ class Typer extends Namer
def typedParent(tree: untpd.Tree): Tree = {
var result = if (tree.isType) typedType(tree)(superCtx) else typedExpr(tree)(superCtx)
val psym = result.tpe.typeSymbol
if (seenParents.contains(psym)) ctx.error(i"$psym is extended twice", tree.pos)
if (seenParents.contains(psym) && !cls.isRefinementClass)
ctx.error(i"$psym is extended twice", tree.pos)
seenParents += psym
if (tree.isType) {
if (psym.is(Trait) && !cls.is(Trait) && !cls.superClass.isSubClass(psym))
Expand Down
7 changes: 7 additions & 0 deletions tests/pos/i4623.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
trait Test {
type A <: Any { type T }
type B <: Any { type T }
type C <: A with B { type T }

type D <: List[A] with List[B] { type T }
}