Fix signature caching in NamedType #4593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Underdefined signatures cannot be cached, this matches the logic in MethodicType. I haven't managed to create a testcase that fails without this, but it should be the Right Thing to do anyway.
Avoid duplication between MethodicType and NamedType
`fixSignature` no longer exists. Instead, we expect the users of signatures to not cache underdefined signatures.
smarter
force-pushed
the
fix/signature-caching
branch
from
ab2ddb9 to
3652d94
Compare
Member
Author
|
test performance please |
Member
|
performance test scheduled: 6 job(s) in queue, 1 running. |
Member
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4593/ to see the changes. Benchmarks is based on merging with master (0b55397) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.