Remove DotClass #4545
Merged
Remove DotClass #4545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
test performance please |
Member
|
performance test scheduled: 1 job(s) in queue, 0 running. |
Member
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4545/ to see the changes. Benchmarks is based on merging with master (f9f9f4a) |
Contributor
|
This does not seem to impact performance... What's the point of that DotClass? Should we merge anyway? |
smarter
force-pushed
the
opt/remove-DotClass
branch
from
da99c31 to
090030a
Compare
smarter
force-pushed
the
opt/remove-DotClass
branch
4 times, most recently
from
dd9a46f to
19df810
Compare
|
|
||
| /** Throws an `UnsupportedOperationException` with the given method name. */ | ||
| def unsupported(methodName: String): Nothing = | ||
| throw new UnsupportedOperationException(s"$getClass.$methodName") |
Contributor
There was a problem hiding this comment.
I guess getClass doesn't make much sense anymore
It's not actually useful for anything and could potentially be detrimental to performance as the JVM will switch from a constant-time to a linear-time lookup for "instanceof" when the class hierarchy is too tall.
smarter
force-pushed
the
opt/remove-DotClass
branch
from
19df810 to
ecb69ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.