Pickle quotes directly as expressions in TASTY #4538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We avoid having to do owner changes after unpickling * The pickled code is slightly smaller
Contributor
Author
|
test performance with #quotes please |
Member
|
performance test scheduled: 1 job(s) in queue, 0 running. |
Member
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4538/ to see the changes. Benchmarks is based on merging with master (df00a67) |
Contributor
Author
|
And performance improvements all around :) |
1 similar comment
Contributor
Author
|
And performance improvements all around :) |
smarter
approved these changes
May 17, 2018
| rdr.indexStats(reader.endAddr) | ||
| } | ||
|
|
||
| def unpickleExpr()(implicit ctx: Context): Tree = { |
Member
There was a problem hiding this comment.
Document what this method does, how it differs from unpickle(), when it is used
Member
|
I wonder if we could always unpickle as an expression and get rid of the other way to unpickle. |
Contributor
Author
|
Do you mean get rid of |
Contributor
Author
|
I will merge the two unpicking ways in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #4242