Fix printing of classes with companion objects in the decompiler (#4526) #4533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…la#4526) This fixes printing of classes with companion objects so that they don't appear on the same line. Example case: class Foo object Foo will be decompiled into class Foo() {} object Foo {} where before they would be printed on the same line, failing compilation.
dottybot
reviewed
May 15, 2018
Member
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
nicolasstucki
approved these changes
May 15, 2018
Contributor
|
Thanks @fschueler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes printing of classes with companion objects so that they don't appear on the same line as described in #4526.
Example case:
will be decompiled into
whereas before they would be printed on the same line, failing compilation.
Thanks to @nicolasstucki for mentoring this during the Scala Spree in Berlin!