Fix #4493 and #4514 #4518
Merged
Fix #4493 and #4514 #4518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biboudis
approved these changes
May 17, 2018
Contributor
biboudis
left a comment
biboudis
left a comment
There was a problem hiding this comment.
LGTM apart from a small question.
| def inSplice = outer != null && !inQuote | ||
|
|
||
| /** We are not in a `~(...)` or a `'(...)` */ | ||
| def isRoot = outer != null |
Contributor
There was a problem hiding this comment.
Hmm. I am confused. Isn't this root if the outer is null according to line 128 above?
(also a typo in the comment of the description of the parameter outer )
Contributor
Author
There was a problem hiding this comment.
Actually it is a typo. It should be isNotRoot
Contributor
Author
There was a problem hiding this comment.
Or I will simplify it to an actual isRoot and add the not at call site.
Contributor
There was a problem hiding this comment.
Good to go, then. Thanks!
It was supposed to be `isNotRoot`, now it is actually `isRoot`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use captured type tags for macro type parameters. Before this change we just kept the type and failed when we tied to pickle it.