Skip to content

WIP: Narrow typers error positions #4511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

WIP: Narrow typers error positions #4511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9da492
Ensure `-YshowSuppressedErrors` also affects `UniqueMessagePositions`
Blaisorblade May 9, 2018
67402fd
Narrow position of errors due to `TypeError` to limit hiding
Blaisorblade May 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/reporting/UniqueMessagePositions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ trait UniqueMessagePositions extends Reporter {
*/
override def isHidden(m: MessageContainer)(implicit ctx: Context): Boolean =
super.isHidden(m) || {
m.pos.exists && {
m.pos.exists && !ctx.settings.YshowSuppressedErrors.value && {
var shouldHide = false
for (pos <- m.pos.start to m.pos.end) {
positions get (ctx.source, pos) match {
Expand Down
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/typer/ErrorReporting.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ object ErrorReporting {
import tpd._

def errorTree(tree: untpd.Tree, msg: => Message)(implicit ctx: Context): tpd.Tree =
tree withType errorType(msg, tree.pos)
tree withType errorType(msg, tree.pos.focus)
Copy link
Member

@smarter smarter May 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure anymore that this is a good idea, since it can lead to worse error messages

Copy link
Contributor Author

@Blaisorblade Blaisorblade May 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only desired this effect for one call site: 0f2d1a3. So closing this PR.

Medium-term, I think you'd want positions inside TypeError, but that shouldn't block #4385.


def errorType(msg: => Message, pos: Position)(implicit ctx: Context): ErrorType = {
ctx.error(msg, pos)
Expand Down