Fix #4500 Allow keyword start after numbers #4501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benkobalog
changed the title
Contributor
|
Wrong issue number in commit message |
Contributor
Author
|
I fixed it @allanrenucci |
| if (n.isUpper && (keywordStart || prev == '.')) { | ||
| appendWhile(n, !typeEnders.contains(_), typeDef) | ||
| } else if (keywordStart) { | ||
| } else if (keywordStart || prev.isDigit) { |
Contributor
There was a problem hiding this comment.
Shouldn't you fix keywordStart instead?
Contributor
Author
There was a problem hiding this comment.
I was thinking about it too and maybe I should have asked first.
The other place where keywordStart is used is type ascriptions (the if just before the one I modified). And as far as I know there is no situation where a number literal can precede a type ascription. For this reason I only added it here.
But maybe it would be better to add it to keywordStart.
allanrenucci
force-pushed
the
fix-#4500
branch
from
22e6e4f to
1629f99
Compare
allanrenucci
approved these changes
Aug 28, 2018
Contributor
allanrenucci
left a comment
allanrenucci
left a comment
There was a problem hiding this comment.
Sorry @benkobalog. I forgot about this PR.
I think the fix has to go in keywordStart. I rebased the PR and appended a commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.