Create {And,Or}TypeTree in Parsers, not desugar #4424
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new API is required for all use cases in this PR.
Fix scala#4373. The testcase is from examples in scala#4373, variations and tests for types with wildcards. I'm unsure for a couple cases.
Without this commit, the testcase produces additional spurious errors: ```scala -- [E104] Syntax Error: tests/neg/i4373.scala:10:0 ----------------------------- 10 |class A2 extends _ with _ // error // error |^ |class Any is not a trait longer explanation available when compiling with `-explain` -- [E104] Syntax Error: tests/neg/i4373.scala:11:21 ---------------------------- 11 |class A3 extends Base with _ // error | ^ | class Any is not a trait longer explanation available when compiling with `-explain` -- Error: tests/neg/i4373.scala:12:24 ------------------------------------------ 12 |class A4 extends _ with Base // error | ^^^^ |illegal trait inheritance: superclass Any does not derive from trait Base's superclass Object ``` These errors make absolutely no sense for a user, since they refer to code the user didn't write, but that was generated by the compiler's error correction mechanism. I haven't checked if we could use `Ident(nme.ERROR)` everywhere. I have also tried using `EmptyTree` and `EmptyTree.withPos(wildcardPos)` and `EmptyTree.clone.withPos(wildcardPos)` as fallback trees, but all of them failed in some way.
TODO: make checkWildcard private to Parsers again.
6 tasks
odersky
reviewed
May 1, 2018
Contributor
odersky
left a comment
odersky
left a comment
There was a problem hiding this comment.
As I wrote in my comment in the other thread, this loses the position of the operator. You can't hover over the operator and get its type or go to its definition anymore. So I don't think this is a good idea.
odersky
approved these changes
May 1, 2018
Contributor
odersky
left a comment
odersky
left a comment
There was a problem hiding this comment.
Edit: Since this is not a real operator it looks like we don't need its position after all. So, LGTM.
Blaisorblade
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 1, 2018
Essentially reviewed in scala#4424.
Blaisorblade
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 2, 2018
Essentially reviewed in scala#4424.
Blaisorblade
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 7, 2018
Essentially reviewed in scala#4424.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring on top of #4422, suggested by @smarter, WIP.
checkWildcardprivate to Parsers again.