Remove some implicit conversions #4312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierBlanvillain
force-pushed
the
cleanup-megamorphic-calls-3
branch
2 times, most recently
from
79d2225 to
9830806
Compare
nicolasstucki
approved these changes
May 8, 2018
| case class MultiDenotation(denot1: Denotation, denot2: Denotation) extends Denotation(NoSymbol, NoType) with MultiPreDenotation { | ||
| final def infoOrCompleter = multiHasNot("info") | ||
| final def info(implicit ctx: Context) = infoOrCompleter | ||
| // final def info(implicit ctx: Context) = infoOrCompleter |
Contributor
|
@OlivierBlanvillain this PR needs a rebase |
OlivierBlanvillain
changed the title
OlivierBlanvillain
force-pushed
the
cleanup-megamorphic-calls-3
branch
from
9830806 to
70fcd52
Compare
OlivierBlanvillain
force-pushed
the
cleanup-megamorphic-calls-3
branch
from
119b788 to
08197ef
Compare
| case class MultiDenotation(denot1: Denotation, denot2: Denotation) extends Denotation(NoSymbol, NoType) with MultiPreDenotation { | ||
| final def infoOrCompleter = multiHasNot("info") | ||
| final def info(implicit ctx: Context) = infoOrCompleter | ||
| // final def info(implicit ctx: Context) = infoOrCompleter |
| @@ -0,0 +1,41 @@ | |||
| import dotty.tools.dotc._ | |||
Contributor
There was a problem hiding this comment.
This file was removed from master
Contributor
|
It is impossible to review the merge commit. Could you rebase instead. |
OlivierBlanvillain
force-pushed
the
cleanup-megamorphic-calls-3
branch
2 times, most recently
from
d7ae2b1 to
f1853c7
Compare
nicolasstucki
approved these changes
Jul 25, 2018
Contributor
|
Needs a rebase to remove the |
OlivierBlanvillain
force-pushed
the
cleanup-megamorphic-calls-3
branch
from
f1853c7 to
7f89686
Compare
OlivierBlanvillain
force-pushed
the
cleanup-megamorphic-calls-3
branch
from
7f89686 to
a55dae9
Compare
Blaisorblade
approved these changes
Aug 3, 2018
Contributor
Blaisorblade
left a comment
Blaisorblade
left a comment
There was a problem hiding this comment.
Everything LGTM here, also because all controversial changes were screened in #4077 (haven't re-double-checked), and the extra boilerplate is always limited (even the Context -> ContextBase touches few lines).
Contributor
|
Leaving merge to @OlivierBlanvillain in case there's any other concern I don't know about, but I think we're good! 🎉 |
nicolasstucki
approved these changes
Aug 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsumes #4077 as a new PR to keep the per commit comments. I addressed the comments in the original PR and removed the commits that where not marked lgtm, expect for the PreName one to continue the discussion, see this comment.