Fix #4291: Copy sticky attachments in TreeCopier
#4292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sticky attachments are attachments whose key is a subclass of `StickyKey`. Those attachments should be copied when a tree is copied using a `TreeCopier`. Fixes scala#4291
Contributor
Author
|
test performance please |
Member
|
performance test scheduled: 4 job(s) in queue, 1 running. |
Member
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4292/ to see the changes. Benchmarks is based on merging with master (4058393) |
odersky
approved these changes
Apr 27, 2018
Contributor
odersky
left a comment
odersky
left a comment
There was a problem hiding this comment.
I agree it's good to have this functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sticky attachments are attachments whose key is a subclass of
StickyKey. Those attachments should be copied when a tree is copiedusing a
TreeCopier.Fixes #4291