Skip to content

Conversation

@nicolasstucki
Copy link
Contributor

No description provided.

@Blaisorblade
Copy link
Contributor

Blaisorblade commented Apr 10, 2018

The failure seems spurious (http://dotty-ci.epfl.ch/lampepfl/dotty/4365/4 has a timeout, while the same test on the parent succeeded http://dotty-ci.epfl.ch/lampepfl/dotty/4348/4), but

[error] Test dotty.tools.dotc.CompilationTests.runAll failed: java.lang.AssertionError: Run test failed, but should not, reasons:
[error]   - test 'tests/run-with-compiler/i3947f.scala' timed out, took 219.395 sec

is either misleading or worth investigating (why would a test take 3 minutes to run? was the machine that overloaded?)
EDIT: anyway, orthogonal to this change.

@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Apr 10, 2018

Yes, that test fails from time to time. I have another PR that should improve this. See #4242

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there is no code change?

@nicolasstucki
Copy link
Contributor Author

Because I am only updating the documentation to match the current implementation

@nicolasstucki
Copy link
Contributor Author

@nicolasstucki nicolasstucki merged commit 7b91742 into master Apr 11, 2018
@Blaisorblade Blaisorblade deleted the nicolasstucki-patch-1 branch April 11, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants