Fix #4196: TailRec-optimize methods returning implicit function types #4197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A transformX method can return a Thicket of trees that need to be transformed by subsequent phases, but so far this wasn't the case. No testcase, but this is necessary to make the next commit work properly as `ShortcutImplicits` returns a Thicket of DefDefs that need to be transformed by TailRec
smarter
force-pushed
the
fix/tailrec-implicitfuns
branch
from
cb0eb7c to
8fe42bc
Compare
…types Before `ShortcutImplicits`, calls to such methods are never in tail position since we call `.apply` on them to pass the implicit arguments. By moving `ShortcutImplicits` before `TailRec` we avoid this problem.
smarter
force-pushed
the
fix/tailrec-implicitfuns
branch
from
8fe42bc to
928a559
Compare
odersky
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.