Fix owners of AsFunction applied expressions #4139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Mar 19, 2018
| case _ => super.transform(tree) | ||
| } | ||
| }.transform(ddef.rhs) | ||
| }.transform(ddef.rhs).changeOwner(ddef.symbol, ctx.owner) |
Member
There was a problem hiding this comment.
To be more efficient, you can replace your TreeMap by a TreeTypeMap(oldOwners = ..., newOwners = ...), and avoid the need for changeOwner (which would create its own TreeTypeMap)
Contributor
Author
There was a problem hiding this comment.
Will change it
nicolasstucki
force-pushed
the
fix-asFunction-owner
branch
from
4f51005 to
0edd3cb
Compare
smarter
approved these changes
Mar 19, 2018
Member
smarter
left a comment
smarter
left a comment
There was a problem hiding this comment.
LGTM, but the tests are failing.
Contributor
Author
|
Tests are failing on maser :( @odersky told me he already has a fix for it. |
Contributor
|
Cherry-picked likely fix in #4141. |
Contributor
|
And new build at http://dotty-ci.epfl.ch/lampepfl/dotty/3824 |
nicolasstucki
force-pushed
the
fix-asFunction-owner
branch
from
0edd3cb to
acc662e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.