Fix #3984: SAM closures returning Unit may need adaptation #3988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix-closure-unit
branch
from
5749ca0 to
5fdbe42
Compare
If the abstract method in a SAM trait has a generic result type that is instantiated to Unit, we need to adapt closures implementing this trait to return BoxedUnit. This isn't necessary for Unit-returning closures without an explicit SAM type because in the backend they're implemented using the `JProcedure*` SAMs (see DottyBackendInterface#Closure) that already handle adapting to BoxedUnit.
smarter
force-pushed
the
fix-closure-unit
branch
from
5fdbe42 to
fdafdc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the abstract method in a SAM trait has a generic result type that is
instantiated to Unit, we need to adapt closures implementing this trait
to return BoxedUnit. This isn't necessary for
Unit-returning closures without an explicit SAM type because in the backend they're implemented
using the
JProcedure*SAMs (see DottyBackendInterface#Closure) thatalready handle adapting to BoxedUnit.