Skip to content

Conversation

@allanrenucci
Copy link
Contributor

No description provided.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding, LGTM.

@allanrenucci
Copy link
Contributor Author

@liufengyun Can you have a look again. I took a different approach to share more code with Driver.scala. I now override process instead of main.


override def newCompiler(implicit ctx: Context): Compiler = new DocCompiler

def compiledDocs(args: Array[String]): collection.Map[String, Package] = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this method since I found no reference for it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring! LGTM

@allanrenucci allanrenucci merged commit 6472ae3 into scala:master Jan 23, 2018
@allanrenucci allanrenucci deleted the dotty-doc branch January 23, 2018 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants