Add IDE tests #3766

nicolasstucki · 2018-01-05T16:29:00Z

No description provided.

allanrenucci · 2018-01-05T16:31:54Z

.drone.yml

+    group: test
+    image: lampepfl/dotty:2017-11-17
+    commands:
+      - cp -R . /tmp/3/ && cd /tmp/3/


Should be a unique directory

smarter · 2018-02-16T01:25:08Z

compiler/src/dotty/tools/dotc/util/DiffUtil.scala

    (fnd, exp, totalChange.toDouble / (expected.length + found.length))
  }

+  def mkColoredLineDiff(expected: Seq[String], actual: Seq[String]): String = {


Add some documentation?

smarter · 2018-02-16T01:25:26Z

language-server/test/dotty/tools/languageserver/CompletionTest.scala

+
+class CompletionTest {
+
+  @Test def competion0: Unit = {


typo: competion -> completion

smarter · 2018-02-16T01:26:55Z

language-server/test/dotty/tools/languageserver/util/Code.scala

+
+import dotty.tools.languageserver.util.embedded._
+
+object Code {


This file, and every other file in this directory would benefit from some documentation.

smarter · 2018-02-16T01:31:58Z

language-server/test/dotty/tools/languageserver/util/Code.scala

+
+        ai.next() match {
+          case emb: CodeMarker =>
+            positions += Tuple3(emb, line, char)


You can use += ((a, b, c))

smarter · 2018-02-16T01:33:30Z

language-server/test/dotty/tools/languageserver/util/Code.scala

+      var char = 0
+      def scan(str: String): Unit = {
+        for (c <- str)
+          if (c == '\n') { line += 1; char = 0 } else { char += 1 }


Isn't this just line = str.count(_ == '\n'); char = str.length - line ?

Not exactly, char needs to be set to 0 when we encounter \n

smarter · 2018-02-16T02:30:57Z

language-server/test/dotty/tools/languageserver/util/actions/CodeDefinition.scala

+
+  override def onMarker(marker: CodeMarker): Exec[Unit] = {
+    val res = server.definition(fix(marker.toTextDocumentPositionParams)).get()
+    assert(res.size() == refOpt.size, res)


size() -> size

res is a java collection, hence it requires size().

It was complaining or waring at the time. I will double check.

smarter · 2018-02-16T02:35:08Z

language-server/test/dotty/tools/languageserver/util/actions/CodeDefinition.scala

+import dotty.tools.languageserver.util._
+import dotty.tools.languageserver.util.embedded.CodeMarker
+
+class CodeDefinition(val range: CodeRange, refOpt: Option[CodeRange]) extends ActionOnRange {


We can return more than one definition.

smarter · 2018-02-16T02:44:04Z

language-server/test/dotty/tools/languageserver/util/embedded/CodeMarker.scala

+
+  def to(other: CodeMarker): CodeRange = CodeRange(this, other)
+
+  def file: PosCtx[TestFile] = implicitly[PositionContext].positionOf(this)._1


You could add implicit def posCtx(implicit ctx: PositionContext): PositionContext = ctx in the class to be able to do posCtx.positionOf ...

smarter · 2018-02-16T03:00:11Z

language-server/test/dotty/tools/languageserver/util/server/TestServer.scala

+       |  "compilerVersion" : "0.6.0-bin-SNAPSHOT-nonbootstrapped",
+       |  "compilerArguments" : [ "-feature", "-deprecation", "-unchecked", "-Xfatal-warnings", "-encoding", "UTF8", "-language:existentials,higherKinds,implicitConversions" ],
+       |  "sourceDirectories" : [ "$baseDir/out/ide-tests/src" ],
+       |  "dependencyClasspath" : [ "$baseDir/library/../out/bootstrap/dotty-library-bootstrapped/scala-0.7/classes", "$ivyDir/cache/org.scala-lang/scala-library/jars/scala-library-2.12.4.jar" ],


The hardcoded version number should be fixed before this is merged.

smarter · 2018-02-16T03:02:49Z

language-server/test/dotty/tools/languageserver/util/SymInfo.scala

+import dotty.tools.languageserver.util.PositionContext._
+import org.eclipse.lsp4j._
+
+class SymInfo(name: String, kind: String, range: CodeRange, container: String) {


use SymbolKind for kind instead of String ?

smarter · 2018-02-22T07:07:11Z

Java methods can be called without parenthesis.

smarter

This looks great!

smarter · 2018-04-11T13:25:42Z

language-server/test/dotty/tools/languageserver/util/actions/CodeCompletion.scala

    val result = server.completion(marker.toTextDocumentPositionParams).get()
-    assert(result.isRight, result)
-    assert(!result.getRight.isIncomplete, s"Completion results were 'incomplete': $result")
+    assertTrue(s"Completion results where not 'right': $result", result.isRight)


typo: where -> where

smarter · 2018-04-11T13:27:03Z

language-server/test/dotty/tools/languageserver/util/CodeTester.scala

+   *
+   * @see dotty.tools.languageserver.util.actions.CodeHover
+   */
+  def hover(range: CodeRange, expected: String): CodeTester =


This method and the following ones could return this.type instead of CodeTester, that way you don't have to document @return, it's obvious.

Duhemm · 2018-04-12T09:31:06Z

@nicolasstucki Do you want to add something?

nicolasstucki

Changes from @Duhemm LGTM

allanrenucci · 2018-04-12T10:02:01Z

@Duhemm Can you please merge master into topic/sbt1 if this happens to be merged before sbt1?

While working on the IDE tests, I noticed that the Dotty IDE didn't behave as I expected in the following scenario: // Rename `Foo` to `Bar` class Foo { new Foo } The Dotty IDE would consider that 3 places need changing, instead of only 2: - The `Ident(Foo)` in the `TypeDef` - The `Ident(Foo)` in the constructor - The `Ident(Foo)` in `Select(new Foo, <init>)` The third tree, however is synthetic: it doesn't need to be changed in the editor. Trees whose positions are not derived from the source are now excluded when doing a rename.

nicolasstucki added the stat:wip label Jan 5, 2018

allanrenucci reviewed Jan 5, 2018

View reviewed changes

nicolasstucki force-pushed the ide-tests branch 4 times, most recently from f9185a4 to 315f0f8 Compare January 5, 2018 17:26

nicolasstucki requested a review from smarter January 5, 2018 18:03

nicolasstucki force-pushed the ide-tests branch 3 times, most recently from f159168 to 55175f0 Compare January 7, 2018 19:13

nicolasstucki added stat:needs review and removed stat:wip labels Jan 8, 2018

nicolasstucki assigned smarter Jan 8, 2018

nicolasstucki force-pushed the ide-tests branch 4 times, most recently from 134878d to 0f93ed8 Compare January 16, 2018 14:32

nicolasstucki force-pushed the ide-tests branch from 0f93ed8 to 204f82e Compare January 17, 2018 08:30

smarter force-pushed the ide-tests branch from 204f82e to cc8bab2 Compare February 12, 2018 10:53

nicolasstucki force-pushed the ide-tests branch 3 times, most recently from 4411728 to e2e0846 Compare February 15, 2018 16:42

smarter reviewed Feb 16, 2018

View reviewed changes

nicolasstucki assigned nicolasstucki and unassigned smarter Feb 22, 2018

allanrenucci assigned Duhemm and unassigned nicolasstucki Mar 26, 2018

allanrenucci removed the stat:needs review label Mar 26, 2018

Duhemm force-pushed the ide-tests branch from e2e0846 to 3e47ac7 Compare March 29, 2018 07:09

Duhemm assigned smarter and nicolasstucki Apr 11, 2018

smarter approved these changes Apr 11, 2018

View reviewed changes

nicolasstucki commented Apr 12, 2018

View reviewed changes

allanrenucci removed their request for review April 12, 2018 11:05

nicolasstucki and others added 19 commits April 12, 2018 18:55

Add IDE tests

64e8920

Add documentation for DiffUtil.mkColoredLineDiff

0d01da8

Typo: competion -> completion

480f6a2

Use JUnit to run IDE tests

1fa3a93

Generate config for IDE tests with sbt-buildinfo

f8498b7

Use SymbolKind in SymInfo

2e5211e

Support multiple results in CodeDefinition

cc0cb29

Add documentation for the IDE tests

4aa5827

Use CompletionItemKind in CodeCompletion

a31baf0

Use JavaConverters in CodeDefinition

c1d6a8a

Address review comments

8cb7a92

Use DocumentHighlightKind instead of strings

b0f9c9a

Refactor TestServer

2832527

Add documentation for Embedded

bfe5387

Address review comments

0aef2d2

Revive commented-out test

2a511ea

Cleanup

73f1112

Address review comments

ef978a7

Duhemm force-pushed the ide-tests branch from f5deadb to ef978a7 Compare April 12, 2018 17:04

Duhemm merged commit 0ba6d2e into scala:master Apr 12, 2018

Duhemm deleted the ide-tests branch April 12, 2018 17:29

allanrenucci mentioned this pull request Jun 3, 2019

Meta-issue: IDE improvements lampepfl/dotty-feature-requests#42

Open

19 tasks


		import dotty.tools.languageserver.util.embedded._

		object Code {


		def to(other: CodeMarker): CodeRange = CodeRange(this, other)

		def file: PosCtx[TestFile] = implicitly[PositionContext].positionOf(this)._1

Add IDE tests #3766

Add IDE tests #3766

Uh oh!

Conversation

nicolasstucki commented Jan 5, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smarter Feb 16, 2018 • edited by allanrenucci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smarter commented Feb 22, 2018 via email

Uh oh!

smarter left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Duhemm commented Apr 12, 2018

Uh oh!

nicolasstucki left a comment

Choose a reason for hiding this comment

Uh oh!

allanrenucci commented Apr 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

smarter Feb 16, 2018 •

edited by allanrenucci

Loading