Fix MatchError: InfixOp on TreeAccumulator #3487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of errors it may be that typed trees point to untyped ones. I think it makes sense to avoid the MatchError in that case, not only in Interative mode.
Contributor
|
This code snippet also causes a match error because of an untyped tree. class Test[T](f: List[String] => T)
object o {
implicit object a extends Test(_ map identity)
implicit object b extends Test(_ map identity)
}Not sure it is related |
odersky
reviewed
Nov 16, 2017
Contributor
odersky
left a comment
odersky
left a comment
There was a problem hiding this comment.
What was a scenario where the error happened? Can it be avoided? If possible I'd like to keep the assert because it looks useful to flag error situations.
Contributor
Author
|
The test case included in the PR throws a match error on master (note that |
odersky
requested changes
Dec 7, 2017
| case Thicket(ts) => | ||
| this(x, ts) | ||
| case _ if ctx.mode.is(Mode.Interactive) => | ||
| case _ => |
Contributor
There was a problem hiding this comment.
Proposal: replace with
case _ if ctx.errorsReported || ctx.mode.is(Mode.Interactive) =>
and adapt the comment to say that in interactive mode, errors might come from previous runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of errors it may be that typed trees point to untyped ones. I think it makes sense to avoid the MatchError in that case, not only in Interative mode.