fix version check in Cygwin #3331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Actually I don't think there is a trailing whitespace. All the lines in the CI log have a space at the end. Have you just tried |
Contributor
Author
|
Yes, I also tried just use double brackets, it didn't work either. |
liufengyun
force-pushed
the
fix-cygwin
branch
from
391f3ec to
f201d79
Compare
Contributor
Author
|
The CI shows it works for MingW and Cygwin. |
allanrenucci
approved these changes
Oct 23, 2017
Contributor
allanrenucci
left a comment
allanrenucci
left a comment
There was a problem hiding this comment.
LGTM. Thanks @liufengyun. I will upload the new artefacts to Dotty release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix version check in Cygwin
Note: I've tried following code as well, which doesn't work either on Cygwin:
I've tried compare
$JAVA_VERSION == "1.8 ", which is false as well. I guess Cygwin has inserted some invisible characters somewhere.