Avoid creating NumericRange instances when not needed #3289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
test performance please |
Member
|
performance test scheduled: 3 job(s) in queue, 1 running. |
Member
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3289/ to see the changes. Benchmarks is based on merging with master (badc855) |
odersky
approved these changes
Oct 9, 2017
| val argParams = | ||
| for (i <- List.range(1, arity + 1)) yield | ||
| enterTypeParam(cls, paramNamePrefix ++ "T" ++ i.toString, Contravariant, decls) | ||
| val argParams = List.tabulate(arity) { i => |
smarter
reviewed
Oct 9, 2017
| val startOffset = source.offsetToLine(start) | ||
| val endOffset = source.offsetToLine(end + 1) | ||
| if (startOffset >= endOffset) line :: Nil | ||
| else List.tabulate(endOffset - startOffset)(i => i + startOffset) |
Member
There was a problem hiding this comment.
Removing the offset to add it back is confusing, I would just keep the original code here since it shouldn't be performance-sensitive, or do (startOffset to endOffset).toList maybe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing NumericRange instances is expensive due to the implicit class tags used.