move 'extend final class' to error class #3283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Oct 7, 2017
Member
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
allanrenucci
suggested changes
Oct 9, 2017
Contributor
allanrenucci
left a comment
allanrenucci
left a comment
There was a problem hiding this comment.
Small nitpicks. Otherwise LGTM
| }.expect { (ictx, messages) => | ||
| implicit val ctx: Context = ictx | ||
| assertMessageCount(1, messages) | ||
| val ExtendFinalClass(extendee, parent) :: Nil = messages |
Contributor
There was a problem hiding this comment.
Should probably be extender and not extendee
| val kind = "Syntax" | ||
| val msg = hl"$clazz cannot extend ${"final"} $finalClazz" | ||
| val explanation = | ||
| hl"""A class marked with the ${"final"} keyword cannot be extended by an object or a class""" |
Contributor
There was a problem hiding this comment.
I would simply say "... cannot be extended". For instance, a trait cannot extends a final class either.
Contributor
Author
|
Thanks for the review, I've addressed your points. |
allanrenucci
approved these changes
Oct 9, 2017
Contributor
allanrenucci
left a comment
allanrenucci
left a comment
There was a problem hiding this comment.
LGTM. Thank you for your contribution ! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.