Avoid creating closure for asserts

[nicolasstucki]

No description provided.

[nicolasstucki]

test performance please

[dottybot]

performance test scheduled: 19 job(s) in queue, 1 running.

[odersky]

Did you check the bytecode that this does in fact inline? Just being paranoiac here.

Otherwise LGTM

[nicolasstucki]

Yes it does inline, but the generated code is a bit larger.
I would prefer patching the assert I found problematic by hand.

[nicolasstucki]

While compiling dotty.tools.dotc.core e2f4be6 reduces the time of FlagSet.| from 0.911 sec to 0.010 sec.

I would drop the first commit. The standard library already has this @inline in the Predef.assert but it is ignored by dotty as it is compiled in scala2 mode. My solution may improve it a bit.

[odersky]

I think we can keep the first commit. There are other asserts, where it would be nice to give them a second parameter without fear that a closure will be created.

[dottybot]

performance test failed:

Error line number: 16

[check /data/workspace/bench/logs/pull-3267-10-05-20.54.out for more information]

[dottybot]

performance test failed:

Error line number: 16

[check /data/workspace/bench/logs/pull-3267-10-05-20.54.out for more information]

[dottybot]

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/3267/ to see the changes.

Benchmarks is based on merging with master (af528a1)

[nicolasstucki]

Removed the second commit