Revert "Revert "Add regression tests on optimise"" #3164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1943f4e.
nicolasstucki
force-pushed
the
enable-tests-on-optimise-3
branch
from
8948a38 to
ebc8e5d
Compare
nicolasstucki
force-pushed
the
enable-tests-on-optimise-3
branch
from
ebc8e5d to
b8c4b11
Compare
| } | ||
|
|
||
| @Test def testOptimised: Unit = { | ||
| val outputDir = defaultOutputDir + "optimised/" |
Contributor
There was a problem hiding this comment.
outputDir is never used
Contributor
Author
There was a problem hiding this comment.
supposed to be used in the tree lines bellow
nicolasstucki
force-pushed
the
enable-tests-on-optimise-3
branch
from
b8c4b11 to
2caa7ba
Compare
| val outputDir = defaultOutputDir + "optimised/" | ||
| compileFilesInDir("../tests/pos", defaultOptimised, outputDir).checkCompile() | ||
| compileFilesInDir("../tests/run", defaultOptimised, outputDir).checkRuns() | ||
| compileShallowFilesInDir("../tests/neg", defaultOptimised, outputDir).checkExpectedErrors() |
Contributor
There was a problem hiding this comment.
Should we move each test in its corresponding test group (i.e. compilePos, compileNeg, runAll) to run them in parallel or should we keep them together for clarity?
Contributor
Author
There was a problem hiding this comment.
I would prefer to keep the separated for now because I going to start modifying stuff in the local optimizations. It will be clearer to see where the failures occurred if they happen. There are enough tests in each one to take advantage of parallelism, we can improve it later.
allanrenucci
approved these changes
Sep 25, 2017
Contributor
allanrenucci
left a comment
allanrenucci
left a comment
There was a problem hiding this comment.
Small nitpicks. Otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1943f4e.