Skip to content

Conversation

@smarter
Copy link
Member

@smarter smarter commented Sep 17, 2017

No description provided.

This get rid of two fields when bootstrapping because inner objects are
implemented as lazy vals which in Dotty requires a bitmap field.
@smarter smarter requested a review from odersky September 17, 2017 14:24
@smarter
Copy link
Member Author

smarter commented Sep 17, 2017

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/3136 to see the changes.

Benchmarks is based on merge(s) with master

@smarter
Copy link
Member Author

smarter commented Sep 17, 2017

Visit http://dotty-bench.epfl.ch/3136 to see the changes.

@liufengyun This is a 404 error page, any idea why? :)

@sjrd
Copy link
Member

sjrd commented Sep 17, 2017

Not for me. I can see that page.

@felixmulder
Copy link
Contributor

felixmulder commented Sep 17, 2017 via email

Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@smarter
Copy link
Member Author

smarter commented Sep 17, 2017

Hmm, http://dotty-bench.epfl.ch/3136/ works but http://dotty-bench.epfl.ch/3136 is a 404 for me. Weird.

@smarter
Copy link
Member Author

smarter commented Sep 17, 2017

These results are way too similar to http://dotty-bench.epfl.ch/3133, makes me think there's a missing point in the graph between master and now, or that the settings of the benchmarks changed.

@liufengyun
Copy link
Contributor

liufengyun commented Sep 17, 2017 via email

@smarter
Copy link
Member Author

smarter commented Sep 17, 2017

If I go to https://liufengyun.github.io/bench/3136 I get a 404, if I go to https://liufengyun.github.io/bench/3136/ it works. If I go to https://liufengyun.github.io/bench/3133 it redirects to https://liufengyun.github.io/bench/3133/ and works. ¯\_(ツ)_/¯

@liufengyun
Copy link
Contributor

This seems to be some differing behaviours of different browsers. I've updated the code to always have the ending slash, hope that works reliably across all browsers.

@smarter smarter merged commit 74c835d into scala:master Sep 17, 2017
@allanrenucci allanrenucci deleted the leaner-ctx branch December 14, 2017 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants