Fix #2367: Allow SAM conversion for overloaded functions #2894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If just one of a number of alternatives takes a SAM, allow a lambda argument, just like we do for non-overloaded methods with SAM type parameters.
smarter
approved these changes
Jul 21, 2017
| case SAMType(meth) => argtpe <:< meth.info.toFunctionType() | ||
| case _ => false | ||
| } | ||
| isCompatible(argtpe, formal) || ctx.mode.is(Mode.ImplicitsEnabled) && SAMargOK |
Member
There was a problem hiding this comment.
Maybe add some note that implicit search and SAM conversion are tried at the same time to justify checking ImplicitsEnabled here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If just one of a number of alternatives takes a SAM, allow a lambda argument,
just like we do for non-overloaded methods with SAM type parameters.