Precompute NXTransforms to speedup repeated application of TreeTransformer.macroTransform #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps Annotation transformers which do not need to reinitialise themselves anymore.
…getClass in dotty.
Contributor
Author
|
@odersky please review. |
Contributor
|
LGTM for now. I think we might profit from re-thinking TreeTransformers. It feels like we should be able to arrive at a simpler implementation, now that we know more about the actual use cases. |
odersky
added a commit
that referenced
this pull request
Dec 14, 2014
Precompute NXTransforms to speedup repeated application of TreeTransformer.macroTransform
tgodzik
added a commit
to tgodzik/scala3
that referenced
this pull request
Apr 29, 2025
Backport "Fix scala#21242: Add REPL flag to quit after evaluating init script" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up annotation transformers.
Also speeds up other initializations by calling .getClass less times.