Add include for rendering sidebar in docs #2608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
May 30, 2017
Member
smarter
left a comment
smarter
left a comment
There was a problem hiding this comment.
LGTM, but with this new ordering, you have to scroll to see the "Usage" section, I suggest moving it before the "Reference" section. Also maybe use a different font style for the section names?
felixmulder
force-pushed
the
topic/add-toc
branch
from
a821834 to
939e9aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix mirrors the sidebar in
docs/index.mdby include. Maybe we should consider renamingsidebar.yml => toc.ymlor something similar. But later PR.I was rebooked to 15:30 :(
So still hacking, but boarding is starting...