Skip to content

Conversation

@kasiaMarek
Copy link
Member

@kasiaMarek kasiaMarek requested a review from tgodzik January 22, 2025 12:30
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik
Copy link
Contributor

tgodzik commented Jan 22, 2025

It seems one test is still failing though :/

@kasiaMarek
Copy link
Member Author

kasiaMarek commented Jan 22, 2025

It seems one test is still failing though :/

Seems to be some flaky worksheet test timeout. Let's see if re-run helps

@tgodzik
Copy link
Contributor

tgodzik commented Jan 22, 2025

It seems one test is still failing though :/

Seems to be some flaky worksheet test timeout. Let's see if re-run helps

Ach, if this happens more we might consider removing the module. Or maybe we should remove it anyway since we have all the metals tests now.

@tgodzik tgodzik merged commit 60e9048 into scala:main Jan 22, 2025
29 checks passed
@WojciechMazur WojciechMazur added this to the 3.7.0 milestone Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants