Skip to content

Conversation

@hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Mar 4, 2024

Related to #19839 and #19848

@hamzaremmal hamzaremmal self-assigned this Mar 4, 2024
@hamzaremmal hamzaremmal marked this pull request as ready for review March 6, 2024 10:33
@hamzaremmal hamzaremmal requested a review from bishabosha March 6, 2024 10:35
@hamzaremmal hamzaremmal added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Mar 6, 2024
@bishabosha bishabosha enabled auto-merge March 6, 2024 12:29
@bishabosha bishabosha merged commit 09f38cf into scala:main Mar 6, 2024
@hamzaremmal hamzaremmal deleted the scala/scala3-links branch March 6, 2024 13:15
@hamzaremmal
Copy link
Member Author

@Kordyjan This PR should also be backported. It has a change in the release script and it might affect the release process of 3.4.1 and 3.3.4.

# latest stable dotty version
DOTTY_VERSION=$(curl -s https://api.github.com/repos/lampepfl/dotty/releases/latest | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/')
DOTTY_URL="https://github.com/lampepfl/dotty/releases/download/$DOTTY_VERSION/scala3-$DOTTY_VERSION.zip"
DOTTY_VERSION=$(curl -s https://api.github.com/repos/scala/scala3/releases/latest | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kordyjan here is the change in the sdkman publish script.

@Kordyjan Kordyjan added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Mar 12, 2024
Kordyjan added a commit that referenced this pull request Mar 12, 2024
@Kordyjan Kordyjan added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Mar 12, 2024
@Kordyjan Kordyjan added this to the 3.4.1 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:done This PR was successfully backported.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants