Skip to content

PC: Replace CC with underlying type in completions #19638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2024
Merged

PC: Replace CC with underlying type in completions #19638

merged 1 commit into from
Feb 7, 2024

Conversation

rochala
Copy link
Contributor

@rochala rochala commented Feb 7, 2024

No description provided.

@rochala
Replace CC with underlying type and instantiate type vars in addition…
944c97e 
…al apply completions added syntheticaly by PC
@rochala rochala requested a review from kasiaMarek February 7, 2024 10:32
kasiaMarek
kasiaMarek approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@kasiaMarek kasiaMarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks extremely reasonable. Should this also be ported to metals?

@rochala
Copy link
Contributor Author

rochala commented Feb 7, 2024

Yes, along with other changes. I'll try to do back back porting tomorrow 😅

@rochala rochala merged commit a5b6907 into scala:main Feb 7, 2024
@Kordyjan Kordyjan added this to the 3.4.1 milestone Feb 14, 2024
@tgodzik tgodzik added the area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools label May 8, 2024
WojciechMazur pushed a commit that referenced this pull request Jun 28, 2024
@rochala @WojciechMazur
PC: Replace CC with underlying type in completions (#19638)
ae6e20d 
[Cherry-picked a5b6907]
@WojciechMazur WojciechMazur mentioned this pull request Jun 28, 2024
Merged
WojciechMazur pushed a commit that referenced this pull request Jun 30, 2024
@rochala @WojciechMazur
PC: Replace CC with underlying type in completions (#19638)
248a165 
[Cherry-picked a5b6907]
WojciechMazur pushed a commit that referenced this pull request Jun 30, 2024
@rochala @WojciechMazur
PC: Replace CC with underlying type in completions (#19638)
f7be7e3 
[Cherry-picked a5b6907]
WojciechMazur pushed a commit that referenced this pull request Jun 30, 2024
@rochala @WojciechMazur
PC: Replace CC with underlying type in completions (#19638)
0f2582d 
[Cherry-picked a5b6907]
WojciechMazur added a commit that referenced this pull request Jul 1, 2024
@WojciechMazur
Backport "PC: Replace CC with underlying type in completions" to LTS (#…
9b77c1f 
…20887)

Backports #19638 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasiaMarek kasiaMarek kasiaMarek approved these changes

Assignees

@kasiaMarek kasiaMarek

Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@rochala @kasiaMarek @tgodzik @Kordyjan