Fix #1877: Add forwarders for primitive/generic mixins. #1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-1877
branch
from
48cfff6 to
312b61c
Compare
nicolasstucki
force-pushed
the
fix-1877
branch
from
312b61c to
9f505a4
Compare
DarkDimius
suggested changes
Jan 11, 2017
Contributor
DarkDimius
left a comment
DarkDimius
left a comment
There was a problem hiding this comment.
otherwise LGTM, with two minor preferences:
- I'd propose to make a huge note inside erasure that Mixin inserts erasure-like forwarders
- I'd prefer to extract this to it's own phase. The motivation comes from Valhalla. When\If it happens, we'll need to move mixin before erasure and than this code will need to be rewritten as it will instead change super-class.
| } | ||
| } | ||
|
|
||
| class Foo extends Bar[Boolean](true) with Baz |
Contributor
There was a problem hiding this comment.
need a test with a value class, also it would be nice to check that the method called would be the unboxed one.
Contributor
Author
There was a problem hiding this comment.
Done in mixin-primitive-on-generic-4.scalaand mixin-primitive-on-generic-5.scala and I checked that the method called is the unboxed one.
Contributor
|
LGTM |
DarkDimius
approved these changes
Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.