Skip to content

WIP: changes to community build projects to build with -Yflexible-types #18172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

WIP: changes to community build projects to build with -Yflexible-types #18172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3053139
enable explicit nulls in community build
olhotak Jul 9, 2023
d00a0d0
changes to compile scalacheck with -Yexplicit-nulls
olhotak Apr 12, 2024
bbad251
changes to compile endpoints4s with -Yexplicit-nulls
olhotak Jul 13, 2023
088c0af
add fromNullable method to object Option
olhotak Jul 13, 2023
f489361
changes to compile intent with -Yexplicit-nulls
olhotak Jul 20, 2023
7eb8775
changes to compile verify with -Yexplicit-nulls
olhotak Apr 13, 2024
37c9da9
changes to compile munit with -Yexplicit-nulls
olhotak Apr 13, 2024
fef10b4
disable explicit nulls for scalaXml
olhotak Jul 22, 2023
793d7d5
changes to make scalaParserCombinators compile with -Yexplicit-nulls
olhotak Apr 13, 2024
81090ef
changes to make scodec-bits compile with -Yexplicit-nulls
olhotak Apr 13, 2024
4c9e506
changes to make scodec compile with -Yexplicit-nulls
olhotak Apr 13, 2024
c003e25
changes to make minitest compile with -Yexplicit-nulls
olhotak Apr 13, 2024
e158ada
changes to make scala-collection-compat compile with -Yexplicit-nulls
olhotak Apr 13, 2024
c94cb7e
changes to make cats compile with -Yexplicit-nulls
olhotak Apr 15, 2024
c47ee77
changes to make cats-effect-3 compile with -Yexplicit-nulls
olhotak Apr 15, 2024
f9772fd
disable explicit nulls for scalatest
olhotak Apr 15, 2024
6cbbfcf
changes to make scalatestplus-scalacheck compile with -Yexplicit-nulls
olhotak Jul 29, 2023
43e8bbc
changes to make scalatestplusjunit compile with -Yexplicit-nulls
olhotak Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion community-build/community-projects/cats
Open in desktop
Submodule cats updated from 771c6c to 464582
2 changes: 1 addition & 1 deletion community-build/community-projects/cats-effect-3
Open in desktop
Submodule cats-effect-3 updated 29 files
+6 −6 core/js/src/main/scala/cats/effect/IOApp.scala
+4 −4 core/js/src/main/scala/cats/effect/tracing/TracingPlatform.scala
+2 −2 core/js/src/main/scala/cats/effect/unsafe/FiberMonitor.scala
+2 −2 core/js/src/main/scala/cats/effect/unsafe/IORuntimeCompanionPlatform.scala
+3 −3 core/js/src/main/scala/cats/effect/unsafe/ref/Reference.scala
+1 −1 core/js/src/main/scala/cats/effect/unsafe/ref/ReferenceQueue.scala
+1 −1 core/js/src/main/scala/cats/effect/unsafe/ref/WeakReference.scala
+12 −10 core/jvm/src/main/scala/cats/effect/IOApp.scala
+5 −5 core/jvm/src/main/scala/cats/effect/IOCompanionPlatform.scala
+1 −1 core/jvm/src/main/scala/cats/effect/NonDaemonThreadLogger.scala
+1 −1 core/jvm/src/main/scala/cats/effect/tracing/TracingPlatform.scala
+52 −50 core/jvm/src/main/scala/cats/effect/unsafe/FiberMonitor.scala
+2 −2 core/jvm/src/main/scala/cats/effect/unsafe/IORuntimeCompanionPlatform.scala
+10 −10 core/jvm/src/main/scala/cats/effect/unsafe/LocalQueue.scala
+4 −4 core/jvm/src/main/scala/cats/effect/unsafe/WorkStealingThreadPool.scala
+33 −33 core/jvm/src/main/scala/cats/effect/unsafe/WorkerThread.scala
+12 −12 core/shared/src/main/scala/cats/effect/ArrayStack.scala
+1 −1 core/shared/src/main/scala/cats/effect/CallbackStack.scala
+8 −8 core/shared/src/main/scala/cats/effect/IO.scala
+60 −58 core/shared/src/main/scala/cats/effect/IOFiber.scala
+5 −5 core/shared/src/main/scala/cats/effect/SyncIO.scala
+1 −1 core/shared/src/main/scala/cats/effect/Trace.scala
+4 −4 core/shared/src/main/scala/cats/effect/tracing/RingBuffer.scala
+9 −4 core/shared/src/main/scala/cats/effect/tracing/Tracing.scala
+1 −1 kernel/jvm/src/main/scala/cats/effect/kernel/AsyncPlatform.scala
+3 −3 std/shared/src/main/scala/cats/effect/std/Console.scala
+2 −2 tests/jvm/src/test/scala/cats/effect/IOAppSpec.scala
+11 −11 tests/shared/src/test/scala/cats/effect/IOSpec.scala
+3 −3 tests/shared/src/test/scala/cats/effect/ResourceSpec.scala
2 changes: 1 addition & 1 deletion community-build/community-projects/endpoints4s
Open in desktop
Submodule endpoints4s updated from 3a667a to af057d
2 changes: 1 addition & 1 deletion community-build/community-projects/intent
Open in desktop
Submodule intent updated 6 files
+2 −2 src/main/scala/intent/core/expectations/contain.scala
+0 −1 src/main/scala/intent/runner/TestSuiteRunner.scala
+6 −4 src/test/scala/intent/helpers/TestSuiteRunnerTester.scala
+1 −1 src/test/scala/intent/runner/FocusedTest.scala
+1 −1 src/test/scala/intent/runner/TestSuiteRunnerTest.scala
+4 −4 src/test/scala/intent/suite/TestDiscoveryTest.scala
2 changes: 1 addition & 1 deletion community-build/community-projects/minitest
Open in desktop
Submodule minitest updated 3 files
+1 −1 shared/src/main/scala/minitest/api/Result.scala
+1 −1 shared/src/main/scala/minitest/api/exceptions.scala
+1 −1 shared/src/test/scala/minitest/tests/SimpleTest.scala
2 changes: 1 addition & 1 deletion community-build/community-projects/munit
Open in desktop
Submodule munit updated from 5c77d7 to fec8b7
2 changes: 1 addition & 1 deletion community-build/community-projects/scala-collection-compat
Open in desktop
Submodule scala-collection-compat updated 1 files
+7 −3 compat/src/test/scala/scala/util/UsingTest.scala
2 changes: 1 addition & 1 deletion community-build/community-projects/scala-parser-combinators
Open in desktop
Submodule scala-parser-combinators updated 1 files
+6 −6 shared/src/main/scala/scala/util/parsing/input/PagedSeq.scala
2 changes: 1 addition & 1 deletion community-build/community-projects/scalacheck
Open in desktop
Submodule scalacheck updated from fbfaab to c72a6f
2 changes: 1 addition & 1 deletion community-build/community-projects/scalatestplus-junit
Open in desktop
Submodule scalatestplus-junit updated 2 files
+2 −2 src/main/scala/org/scalatestplus/junit/AssertionsForJUnit.scala
+2 −2 src/main/scala/org/scalatestplus/junit/JUnitTestFailedError.scala
2 changes: 1 addition & 1 deletion community-build/community-projects/scalatestplus-scalacheck
Open in desktop
Submodule scalatestplus-scalacheck updated 1 files
+2 −2 scalatestPlusScalaCheck/src/main/scala/org/scalatestplus/scalacheck/CheckerAsserting.scala
2 changes: 1 addition & 1 deletion community-build/community-projects/scodec
Open in desktop
Submodule scodec updated 1 files
+2 −2 shared/src/main/scala/scodec/codecs/ChecksumFactory.scala
2 changes: 1 addition & 1 deletion community-build/community-projects/scodec-bits
Open in desktop
Submodule scodec-bits updated 1 files
+2 −2 core/shared/src/main/scala/scodec/bits/ByteVector.scala
2 changes: 1 addition & 1 deletion community-build/community-projects/verify
Open in desktop
Submodule verify updated from ae37d7 to 539530
7 changes: 5 additions & 2 deletions community-build/src/scala/dotty/communitybuild/projects.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ object SbtCommunityProject:
def scalacOptions = List(
"-Xcheck-macros",
"-Ysafe-init",
"-Yexplicit-nulls",
)

object projects:
Expand Down Expand Up @@ -290,7 +291,8 @@ object projects:
// Problem parsing scalatest.dotty/target/scala-3.0.0-M2/src_managed/main/org/scalatest/concurrent/ConductorFixture.scala:[602..624..3843], documentation may not be generated.
// dotty.tools.dotc.core.MissingType:
dependencies = List(scalaXml),
testOnlyDependencies = () => List(scalatestplusJunit, scalatestplusTestNG)
testOnlyDependencies = () => List(scalatestplusJunit, scalatestplusTestNG),
scalacOptions = SbtCommunityProject.scalacOptions.filter(_ != "-Yexplicit-nulls")
)

lazy val scalatestplusScalacheck = SbtCommunityProject(
Expand Down Expand Up @@ -319,7 +321,8 @@ object projects:
project = "scala-xml",
sbtTestCommand = "xml/test",
sbtPublishCommand = "xml/publishLocal",
sbtDocCommand = "xml/doc"
sbtDocCommand = "xml/doc",
scalacOptions = SbtCommunityProject.scalacOptions.filter(_ != "-Yexplicit-nulls"),
)

lazy val scalap = SbtCommunityProject(
Expand Down
1 change: 1 addition & 0 deletions library/src/scala/runtime/stdLibPatches/Predef.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,5 @@ object Predef:
* `eq` or `ne` methods, only `==` and `!=` inherited from `Any`. */
inline def ne(inline y: AnyRef | Null): Boolean =
!(x eq y)
extension (inline opt: Option.type) inline def fromNullable[T](t: T|Null): Option[T] = Option(t).asInstanceOf
end Predef