Skip to content

Add tests for clause interleaving to safe initialization test suite. #16906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2023
Merged

Add tests for clause interleaving to safe initialization test suite. #16906

merged 2 commits into from
Mar 3, 2023

Conversation

q-ata
Copy link
Contributor

@q-ata q-ata commented Feb 14, 2023

Copies the following tests to the safe initialization test suite to ensure the initialization checker can handle clause interleaving.

  • tests/pos/interleaving-params.scala
  • tests/pos/interleaving-overload.scala
  • tests/neg/interleaving-params.scala

@odersky odersky requested a review from smarter February 14, 2023 10:06
@odersky odersky removed the request for review from smarter February 14, 2023 10:06
@olhotak olhotak self-assigned this Feb 14, 2023
olhotak
olhotak reviewed Feb 14, 2023
View reviewed changes
Copy link
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add calls to these methods in the tests. Otherwise LGTM.

@olhotak olhotak merged commit 6ad22aa into scala:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olhotak olhotak olhotak approved these changes

Assignees

@olhotak olhotak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@q-ata @olhotak @smarter