Drop toNoExplanation implicit conversion
#16211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`toNoExplanation` was an old-style implicit conversion. It could not be made a `Conversion` since it was defined over a call-by-name argument. It also hid important implementation details since it delayed constructing the argument. So knowing whether a string would be evaluated strictly or lazily depended on knowing how type inference would work. We replace the conversion by a combination of - an extension method `.toMessage` converting a lazy string explicitly, and - some overloading of core methods that take either a message or a lazy string. We should over time get rid of overloads and convert most strings passed as messges to proper messages. But that will take time. At least by now we see better where the work is needed.
odersky
force-pushed
the
drop-no-explanation
branch
from
38b4b19 to
1a0908c
Compare
dwijnand
approved these changes
Oct 20, 2022
dwijnand
reviewed
Dec 17, 2022
|
|
||
| def error(ex: TypeError, pos: SrcPos)(using Context): Unit = | ||
| error(ex.toMessage, pos, sticky = true) | ||
| if ctx.settings.YdebugTypeError.value then ex.printStackTrace() |
Member
There was a problem hiding this comment.
I missed this removal. Was it intentional? It's the only use of the setting (AFAICT).
Contributor
Author
There was a problem hiding this comment.
I think that was by accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toNoExplanationwas an old-style implicit conversion. It could not be made aConversionsince it was defined over a call-by-name argument. It also hid important implementation details since it delayed constructing the argument. So knowing whether a string would be evaluated strictly or lazily depended on knowing how type inference would work.We replace the conversion by a combination of
.toMessageconverting a lazy string explicitly, andWe should over time get rid of overloads and convert most strings passed as messages to proper messages. But that will take time. At least by now we see better where the work is needed.