Supress safe initialization warning in Types.scala #14663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change supresses the following 7 safe-init errors that occur in Types.scala, but are too complicated for the checker to reason about: ``` [error] -- Error: /*******/dotty/compiler/src/dotty/tools/dotc/core/Types.scala:3951:53 [error] 3951 | val paramInfos: List[TypeBounds] = paramInfosExp(this) [error] | ^^^^ [error] |Cannot prove that the value is fully initialized. Only initialized values may be used as arguments. [error] -- Error: /*******/dotty/compiler/src/dotty/tools/dotc/core/Types.scala:3952:38 [error] 3952 | val resType: Type = resultTypeExp(this) [error] | ^^^^ [error] |Cannot prove that the value is fully initialized. Only initialized values may be used as arguments. [error] -- Error: /*******/dotty/compiler/src/dotty/tools/dotc/core/Types.scala:3882:53 [error] 3882 | val paramInfos: List[TypeBounds] = paramInfosExp(this) [error] | ^^^^ [error] |Cannot prove that the value is fully initialized. Only initialized values may be used as arguments. [error] -- Error: /*******/dotty/compiler/src/dotty/tools/dotc/core/Types.scala:3883:38 [error] 3883 | val resType: Type = resultTypeExp(this) [error] | ^^^^ [error] |Cannot prove that the value is fully initialized. Only initialized values may be used as arguments. [error] -- Error: /*******/dotty/compiler/src/dotty/tools/dotc/core/Types.scala:3708:47 [error] 3708 | val paramInfos: List[Type] = paramInfosExp(this) [error] | ^^^^ [error] |Cannot prove that the value is fully initialized. Only initialized values may be used as arguments. Calling trace: [error] | -> extends MethodType(paramNames)(paramInfosExp, resultTypeExp) [ Types.scala:3730 ] [error] | -> abstract case class MethodType(paramNames: List[TermName])( [ Types.scala:3701 ] [error] -- Error: /*******/dotty/compiler/src/dotty/tools/dotc/core/Types.scala:3709:38 [error] 3709 | val resType: Type = resultTypeExp(this) [error] | ^^^^ [error] |Cannot prove that the value is fully initialized. Only initialized values may be used as arguments. Calling trace: [error] | -> extends MethodType(paramNames)(paramInfosExp, resultTypeExp) [ Types.scala:3730 ] [error] | -> abstract case class MethodType(paramNames: List[TermName])( [ Types.scala:3701 ] [error] -- Error: /*******/dotty/compiler/src/dotty/tools/dotc/core/Types.scala:3017:33 [error] 3017 | val parent: Type = parentExp(this) [error] | ^^^^ [error] |Cannot prove that the value is fully initialized. Only initialized values may be used as arguments. ``` Due to the `this` pointer being passed to an external method during initialization, the initialization checker cannot prove that these are safe. Review by @liufengyun
olhotak
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change supresses the following 7 safe-init errors that occur in
Types.scala, but are too complicated for the checker to reason about:
Due to the
thispointer being passed to an external method during initialization, the initialization checker cannot prove that these are safe.Review by @liufengyun