Add context to safe-init warnings for inlined methods #14646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
Mar 8, 2022
Contributor
liufengyun
left a comment
liufengyun
left a comment
There was a problem hiding this comment.
Let's add a test case with a check file to prevent regression. Otherwise, LGTM 🎉
Closes scala#14467 - Adds the calling context of the inlined method to the stack trace for safe-init warnings For source code: ```Scala class InlineError { Assertion.failAssert(this) val v = 2; } object Assertion: transparent inline def failAssert(inline message: => Any): Unit = scala.runtime.Scala3RunTime.assertFailed(message) ``` Old warning: ``` [error] -- Error: /*******/dotty/compiler/src/dotty/tools/dotc/InlineError.scala:10:45 [error] 10 | scala.runtime.Scala3RunTime.assertFailed(message) [error] | ^^^^^^^ [error] |Cannot prove that the value is fully initialized. Only initialized values may be used as arguments. ``` New warning: ``` [error] -- Error: /*******/dotty/compiler/src/dotty/tools/dotc/InlineError.scala:10:45 [error] 10 | scala.runtime.Scala3RunTime.assertFailed(message) [error] | ^^^^^^^ [error] |Cannot prove that the value is fully initialized. Only initialized values may be used as arguments. Calling trace: [error] | -> Assertion.failAssert(this) [ InlineError.scala:4 ] ``` Review by @liufengyun
Xavientois
force-pushed
the
show-context-for-inline-safe-init
branch
2 times, most recently
from
25cf4ed to
18300d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14467
For source code:
Old warning:
New warning:
Review by @liufengyun