Fix Scala.JS source map URIs #14243
Merged
Fix Scala.JS source map URIs #14243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotty publishes release versions without a `v` in the tag, but the Scala.JS source map URI configuration is published with a `v` prefix. This causes incorrect source map URLs like: https://raw.githubusercontent.com/lampepfl/dotty/v3.1.0/library/src/scala/IArray.scala (this is in the current releases JAR). This commit fixes the source map URIs to no longer use the `v` prefix.
smarter
approved these changes
Jan 10, 2022
Member
|
Thanks for spotting this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dotty publishes release versions without a
vin the tag, but the Scala.JS source map URI configuration is set with avprefix. This causes incorrect source map URLs like: https://raw.githubusercontent.com/lampepfl/dotty/v3.1.0/library/src/scala/IArray.scala (this is in the current latest release JAR).This commit fixes the source map URIs to no longer use the
vprefix. Resulting in a URL like: https://raw.githubusercontent.com/lampepfl/dotty/3.1.0/library/src/scala/IArray.scala (for a next release)