Accept supplementary characters #13136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
forward/supplementary
branch
3 times, most recently
from
1dc80cf to
7dd2a52
Compare
som-snytt
commented
Jul 24, 2021
Contributor
Author
|
Includes mild Will fix the f-interpolator format strings once f-interpolator is fixed. |
dwijnand
approved these changes
Jul 28, 2021
Member
dwijnand
left a comment
dwijnand
left a comment
There was a problem hiding this comment.
LGTM, but it's not my area of expertise so I'll merge it in a few days to see if there are other reviewers.
som-snytt
force-pushed
the
forward/supplementary
branch
from
7dd2a52 to
87e8373
Compare
som-snytt
force-pushed
the
forward/supplementary
branch
from
87e8373 to
cf29787
Compare
Contributor
Author
|
Rebased, but let's wait a few more days. |
Contributor
It's been a few days 😉 Merge now? |
Contributor
|
@som-snytt Nice refactoring ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port scala/scala#9687
Fixes #13045