Add missing case for finding default getters #13018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two modes for finding default getters. They depend on whether the receiver is defined or not. If the receiver is not defined we search the enclosing scopes instead. This fails if the method and the call are in different toplevel files, since the scopes of the two are not enclosing. But that should not matter since for toplevel definitions we do have a defined receiver, namely the synthetic enclosing object. Only for extension methods it happened that that object was referred to via a This reference instead of a TermRef. This is allowed in general but fell through a missing case in this instance. Fixes scala#12897
smarter
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two modes for finding default getters. They depend on whether
the receiver is defined or not. If the receiver is not defined we search
the enclosing scopes instead. This fails if the method and the call are in different
toplevel files, since the scopes of the two are not enclosing. But that should
not matter since for toplevel definitions we do have a defined receiver, namely
the synthetic enclosing object. Only for extension methods it happened that
that object was referred to via a This reference instead of a TermRef. This is
allowed in general but fell through a missing case in this instance.
Fixes #12897