Avoid exponential retries on inlining overflow #12139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some situations Typer tries several alternatives around an inlined call. If overflow is detected at depth 32 then this could cause 2^32 different retries which leads to OOM. Prevent this with a switch that stops further inline calls as long as an overflowing call stack is not completely unwound. Fixes scala#12116
nicolasstucki
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations Typer tries several alternatives around an inlined call. If overflow is detected
at depth 32 then this could cause 2^32 different retries which leads to OOM.
Prevent this with a switch that stops further inline calls as long as an overflowing call stack
is not completely unwound.
Fixes #12116