Neg tests: remove xerror parameter from neg tests (#1110) #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/test/CompilerTest.scala
Outdated
| val nerrors = reporter.errorCount | ||
| val xerrors = (expectedErrorsPerFile map {_.totalErrors}).sum | ||
| if (negTest) | ||
| assert((negTest && xerrors > 0), s"No errors found in neg test") |
Contributor
Author
|
Update: now we don't need negTest flag anymore; neg tests are binded to neg dir (changes are added in dotty-staging@de7e377) |
test/test/CompilerTest.scala
Outdated
| if (!generatePartestFiles || !partestableDir(prefix, dirName, args ++ defaultOptions, xerrors)) { | ||
| if (runTest) | ||
| log(s"WARNING: run tests can only be run by partest, JUnit just verifies compilation: $prefix$dirName") | ||
| val computeFilePathsAndExpErrors = { () => |
Contributor
There was a problem hiding this comment.
I see no reason why this should be a val. Make it a def?
Contributor
Author
There was a problem hiding this comment.
Fixed in last commit
Contributor
|
Otherwise LGTM |
odersky
added a commit
that referenced
this pull request
Mar 3, 2016
Neg tests: remove xerror parameter from neg tests (#1110)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neg tests at the moment take expected number of errors as an argument. Since #1106 we can optionally mark lines where errors are expected.
With this change we don't need to pass the expected number of errors as an argument to neg tests anymore. In addition most of the neg files don't require separate test (except for files that should use specific arguments for compilation or directories that should be compiled inside
negdir):New subfolders in neg dir:
compExceptions- contains tests that result in exception during the compilation (currently only structural.scala);customArgs- contains neg tests that should be compiled with specific arguments;Several files were in neg dir but were not added to
tests.scalaas tests. Now they became a part of neg_all test:Several files that were in neg dir have no compilation errors. Now they are moved to pos tests:
Related issue: #1110
Review by @DarkDimius